[Core-JDK-Vertx-Matrix] Added JDK and Vertx Http Clients dependencies to all libraries.#39279
Merged
mssfang merged 8 commits intoAzure:mainfrom Mar 28, 2024
Merged
Conversation
mssfang
requested review from
AikoBB,
maximrytych-ms and
mjafferi-msft
as code owners
Contributor
Author
|
/azp run java - azure-communication-identity - tests |
|
No pipelines are associated with this pull request. |
1 similar comment
|
No pipelines are associated with this pull request. |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mssfang
requested review from
JimSuplizio,
benbp,
hallipr and
weshaggard
as code owners
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mssfang
changed the title
alzimmermsft
approved these changes
Mar 27, 2024
mssfang
requested review from
a team,
Aashish93-stack,
JonathanGiles,
LarryOsterman,
RoyHerrod,
allchiang-msft,
anilba06,
ankitarorabit,
besh2014,
cochi2,
danielav7,
gfeitosa-msft,
gkostal,
ilyapaliakou-msft,
joshfree,
juntuchen-msft,
miguhern,
mikehang-msft,
minnieliu,
minwoolee-msft,
paolamvhz,
phermanov-msft,
samvaity,
shwali-msft,
sjiherzig,
srnagar and
whisper6284
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
JDKandVertXHTTP clients dependences to the client libraries. (Fact: those libraries use OkHttpClient as well, just align in a group of Httpclient in Test-Scope azure-sdk-for-java supports, we support netty, okhttp, jdk, and vertx http clients up to today)Note:
If see error below, to add the jdkhttpclient dependency to pass the pipeline, same as this PR.